adding independent publisher check #9917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbarnes
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks good to me. Thanks, @DebbieSan!
Let's just go with this current list for now and if we have to change it again, we will.
|
A next step may be to add "createspace" to the block list unless it's a promise item. I've recently seen a spike in these imports. Createspace is the former name of Amazon's POD service. We do sometimes have corresponding IA items matching the ISBNs, but this is a small fraction of the imported records. Unless there's a way to filter out the genuinely self-published titles from the public domain reprints, we should block the imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9462
Prevents independent publisher from importing. Previously only independently published was prevented. This PR expands this criteria to ensure independent publisher is not imported.
Technical
This PR only adds independent publisher as requested in issue #9462. However, we might want to add more publishers to this list as per https://openlibrary.org/search/publishers?q=independent+publisher
Testing
Testing is included. See tests.
Stakeholders
@scottbarnes @seabelis